FINERACT-821 Added and Enforced LeftCurly Checkstyle - #1060
Merged
Conversation
Member
Author
|
RightCurly checkstyle will follow this, it was probably possible to add it in this one. I sticked to the rule of one checkstyle per PR. |
vorburger
approved these changes
Jun 15, 2020
vorburger
left a comment
Member
There was a problem hiding this comment.
LGTM. Not individually reviewed line by line. @thesmallstar was this automatically reformatted by Spotless, or manually?
Member
Author
|
Automatically done by spotless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to change the formatter.xml to enforce this change, most of the changes are directly enforced by spotless.