Skip to content

Fineract 1012:Spring Security OAuth 2.x to Spring Security 5.2.x - #1104

Closed
Wandji69 wants to merge 9 commits into
apache:developfrom
Wandji69:FINERACT-1012
Closed

Fineract 1012:Spring Security OAuth 2.x to Spring Security 5.2.x#1104
Wandji69 wants to merge 9 commits into
apache:developfrom
Wandji69:FINERACT-1012

Conversation

@Wandji69

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@awasum

awasum commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

Hi @Wandji69 . Thanks for the PR. It looks like you modified the embedded Gradle Wrapper ( gradlew ) in a way that made this PR to fail on Travis as seen here: https://travis-ci.org/github/apache/fineract/builds/701349450 throwing a class not found exception.
Is this a new error?

Also try to squash your PRs in to 1 commit when possible so we have a clean commit history.

This saves a few seconds ;) in the build, and (more importantly)
makes it easier to find all the project's @disabled (formerly @ignore) tests.
@durrantk

Copy link
Copy Markdown

I’m looking into this but have not push. I will also squash.

@awasum

awasum commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

Are @durrantk and @Wandji69 paring on this PR? if so make sure to use the Co-Author feature for Git and Github. See: https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

@awasum

awasum commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

But it will be easier for one person to get this work done..instead of 2. Is this really that complicated or you all are just learning?

@Wandji69 Wandji69 closed this Jun 25, 2020
@Wandji69
Wandji69 deleted the FINERACT-1012 branch June 25, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants