Fineract 1012:Spring Security OAuth 2.x to Spring Security 5.2.x - #1104
Fineract 1012:Spring Security OAuth 2.x to Spring Security 5.2.x#1104Wandji69 wants to merge 9 commits into
Conversation
|
Hi @Wandji69 . Thanks for the PR. It looks like you modified the embedded Gradle Wrapper ( gradlew ) in a way that made this PR to fail on Travis as seen here: https://travis-ci.org/github/apache/fineract/builds/701349450 throwing a class not found exception. Also try to squash your PRs in to 1 commit when possible so we have a clean commit history. |
|
I’m looking into this but have not push. I will also squash. |
|
Are @durrantk and @Wandji69 paring on this PR? if so make sure to use the Co-Author feature for Git and Github. See: https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors |
|
But it will be easier for one person to get this work done..instead of 2. Is this really that complicated or you all are just learning? |
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide