Easier Setup - #117
Closed
avikganguly01 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Can you explain bit more why this change is required? |
Contributor
Author
|
Well, it is always great to be on top of things and use all the latest technologies but if you feel breaking backward compatibility because of one line is fine, then it is your call. The other part of the PR is about easier setup where ServerApplication is by default included in the sourceSet, so for beginners, there won't be any need to change classpath exclusions before firing the server up. Dependency inclusion is because of excluding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change in default exclusion so that ServerApplication and EmbeddedTomcatWithSSLConfiguration are default available in build path.
Inclusion of commons-io dependency as FileUtils in the excluded EmbeddedTomcatWithSSLConfiguration requires this dependency.
Changing sort function used in InterestRateChart to be compatible with Java 7 as well since I believe not all users would have moved to Java 8 by now.