Net Disbursal Amount Feature (FINERACT-1321) - #1841
Merged
Merged
Conversation
Cadreia
marked this pull request as ready for review
August 27, 2021 00:13
Contributor
|
This looks interesting. Thanks for the PR @Cadreia , Can you update the PR to fix the merge conflicts? Sorry for the delay. @Cadreia Does this change have or need a corresponding UI change or PR? |
Contributor
|
Hi @Cadreia - code looks all good, but looks like the build is failing and there are some merge conflicts. Could you resolve these, squash the commits, put the JIRA issue number into the commit message please, and we can then merge this in? Thanks! |
Cadreia
force-pushed
the
nda-feature
branch
from
September 23, 2021 07:27
08bb423 to
245b823
Compare
Contributor
Author
|
Conflicts have been resolved and build passes now. Please review. Link to the PR for the corresponding UI change is in the description above. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.