Skip to content

FINERACT-1670: Fix race condition of CustomAuditingHandler's DateTimeProvider - #2480

Merged
galovics merged 1 commit into
apache:developfrom
adamsaghy:fix-custom-auditing-handler
Aug 4, 2022
Merged

FINERACT-1670: Fix race condition of CustomAuditingHandler's DateTimeProvider#2480
galovics merged 1 commit into
apache:developfrom
adamsaghy:fix-custom-auditing-handler

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@awasum

awasum commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

I see the great work you are doing on Fineract @adamsaghy .

It will be great to create Fineract Issue tickets to work on tasks so that it helps others understand what you are solving and it shows up on the Release notes.. This is invaluable to open source projects like this.

cc @galovics , @vidakovic ,

@adamsaghy

Copy link
Copy Markdown
Contributor Author

@awasum You are right! Let me add some exta information:
This fix is connecting to the work i am doing under this ticket: https://issues.apache.org/jira/browse/FINERACT-1670

@awasum

awasum commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

That's great. Always add the Fineract ticket number to the commit message and PR message. Witubthe infra in place, PRS show in the Jira ticket... Thanks

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics
galovics merged commit 77ca3a2 into apache:develop Aug 4, 2022
@adamsaghy adamsaghy changed the title Fix race condition of CustomAuditingHandler's DateTimeProvider FINERACT-1670: Fix race condition of CustomAuditingHandler's DateTimeProvider Aug 9, 2022
@adamsaghy
adamsaghy deleted the fix-custom-auditing-handler branch January 28, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants