FINERACT-1827: Last installment is not closed if there is a chargeback transaction - #2788
Merged
galovics merged 1 commit intoDec 6, 2022
Conversation
josehernandezfintecheandomx
changed the title
galovics
requested changes
Dec 5, 2022
galovics
left a comment
galovics
left a comment
Contributor
There was a problem hiding this comment.
Title doesn't correspond to any Fineract JIRA, neither the commit.
josehernandezfintecheandomx
force-pushed
the
fix/loan_installment_closed_with_chargeback
branch
from
December 6, 2022 14:34
a08a8d9 to
1a47e1a
Compare
josehernandezfintecheandomx
changed the title
josehernandezfintecheandomx
force-pushed
the
fix/loan_installment_closed_with_chargeback
branch
from
December 6, 2022 15:55
1a47e1a to
3f6fe0c
Compare
josehernandezfintecheandomx
force-pushed
the
fix/loan_installment_closed_with_chargeback
branch
from
December 6, 2022 18:27
3f6fe0c to
2a72c20
Compare
galovics
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ction
Description
In case if a loan is fully paid and there was a chargeback transaction the last installment is not marked as paid/completed.
FINERACT-1827
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.