Skip to content

FINERACT-1678-Config-Bulk-Event-Loan-COB - #2855

Merged
taskain7 merged 1 commit into
apache:developfrom
ruchiD:FINERACT-1678-Config-Bulk-Event-Loan-COB
Jan 5, 2023
Merged

FINERACT-1678-Config-Bulk-Event-Loan-COB#2855
taskain7 merged 1 commit into
apache:developfrom
ruchiD:FINERACT-1678-Config-Bulk-Event-Loan-COB

Conversation

@ruchiD

@ruchiD ruchiD commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Description

Changes to configure bulk events for COB.

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@taskain7 taskain7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taskain7
taskain7 merged commit 4269e3e into apache:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants