FINERACT-1911: Alter datatable - column update, delete fix

[marta-jankovics]

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[marta-jankovics]

I am adding a note on my PR because I would like this change to be approved.
This field was requested to be unique: true, indexed: true already on create. So sending an update request with the indexed flag to be true can not set the unique flag to false. I think this was a bug, but please confirm.

[adamsaghy]

Sounds like a bug...but i am assuming by not sending it is considered the default value then which is false... i am not recalling from the top of my head whether the unique field is mandatory ot not

[marta-jankovics]

Exactly, that was the problem, not sending something on update means no change and not set to default value. If the field is mandatory, then it was already set on insert.

[adamsaghy]

LGTM