Skip to content

[FINERACT-1968] horizontal processing for refund for active loans - #3583

Merged
adamsaghy merged 1 commit into
apache:developfrom
taskain7:horizontal-processing-refund
Nov 14, 2023
Merged

[FINERACT-1968] horizontal processing for refund for active loans#3583
adamsaghy merged 1 commit into
apache:developfrom
taskain7:horizontal-processing-refund

Conversation

@taskain7

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@taskain7
taskain7 force-pushed the horizontal-processing-refund branch from 8a67bae to aed2e1a Compare November 14, 2023 01:09
@taskain7
taskain7 force-pushed the horizontal-processing-refund branch from aed2e1a to 4a79b02 Compare November 14, 2023 11:45
@taskain7
taskain7 force-pushed the horizontal-processing-refund branch from 4a79b02 to e4fe53b Compare November 14, 2023 11:46

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reluxa reluxa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit 71f9f57 into apache:develop Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants