FINERACT-1992: Multi delinquency implication on events - #3595
Conversation
|
@reluxa FYI |
There was a problem hiding this comment.
I think it might make sense to cover the logic which assembles installmentsDelinquencyData with a few unit tests.
|
Have you covered the below scenarios as well?
According to the delinquency event shall be emitted in this case too. Update: |
There was a problem hiding this comment.
According to the design the fields here should have been moved up, like installmentDelinquencyBuckets[n].minimumAgeDays and yours is installmentDelinquencyBuckets[n].delinquencyRange.minimumAgeDays I think it's perfectly fine, but please update the documentation to make it inline with the implementation.
e5b1048 to
3477eb3
Compare
| .setCurrency(currencyMapper.map(data.getCurrency()))// | ||
| .setDelinquentDate(delinquentDate)// | ||
| .build(); | ||
| .setInstallmentDelinquencyBuckets(installmentsDelinquencyData).build(); |
There was a problem hiding this comment.
This should be calculated and set only when the installment level delinquency is enabled on the loan.
There was a problem hiding this comment.
Ah, please ignore, I can see that you are checking it in line 124
There was a problem hiding this comment.
@reluxa , This check is there in calculateInstallmentLevelDelinquencyData method.
private List calculateInstallmentLevelDelinquencyData(Loan loan, LoanAccountData data) {
List loanInstallmentDelinquencyData = new ArrayList<>();
if (loan.isEnableInstallmentLevelDelinquency()) {
|
LGTM |
jdailey
left a comment
jdailey
left a comment
There was a problem hiding this comment.
Review seems good, would like to see more tests
4 participants
Description
Event payload changes to include installment level delinquency data for LoanDelinquencyRangeChangeEvent.
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.