FINERACT-2602: Remove stuck loans from loan lock table after COB execution#5853
Closed
AshharAhmadKhan wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Hey @adamsaghy Please trigger checks when you get a chance, thanks. |
AshharAhmadKhan
force-pushed
the
FINERACT-2602-unlock-processed-loans-after-cob
branch
from
83348f2 to
2ad4eb9
Compare
Contributor
Author
|
@adamsaghy Hey, Can you please retrigger failing checks. Both were flaky. |
Contributor
Author
|
Hi @adamsaghy , just following up on this PR. Would appreciate a review when you get a chance, Thanks! |
Contributor
|
@AshharAhmadKhan I believe you have got a contender: #5858 with a more thorough approach and testing. |
Contributor
Author
|
Thanks @adamsaghy. I took a closer look at #5858, and I agree it’s a better approach than mine for handling this issue. I’ll close this PR to avoid duplicate effort. Glad I got to work on this and understand this part of the COB flow better. I’ll also drop my thoughts/review on #5858 where I think I can help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where loan accounts remain stuck in
m_loan_account_locksafter COB completes successfully.Adds
UnlockProcessedLoansTaskletas the final step in the COB job. It removes orphaned locks where the loan was fully processed (error is null andlock_placed_on_cob_business_datematches the current COB date).Also adds a Cucumber unit test for the new tasklet.
Resolves: https://issues.apache.org/jira/browse/FINERACT-2602