FINERACT-2602: Remove orphaned COB locks after job completion

[oleksii-novikov-onix]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[AshharAhmadKhan]

@oleksii-novikov-onix @adamsaghy

The approach here is solid. A few thoughts on the open review comments:

@Transactional(propagation = REQUIRES_NEW) on removeOrphanedLocksForProcessedAccounts() isn't needed. Spring Batch already wraps each tasklet in its own transaction and all prior steps have committed by the time this runs, so default REQUIRED is fine.

nullCobBusinessDate in LockRequest is there so tests can place a lock with a null cob date through the API, which is needed to cover the lock_placed_on_cob_business_date IS NOT NULL filter in the delete query. Without it there's no way to test that edge case.

Also agree on log.info, log.debug makes more sense since this runs on every COB execution.

[oleksii-novikov-onix]

@AshharAhmadKhan Thank you for participating in the discussion

[adamsaghy]

LGTM