Skip to content

FINERACT-2455: Implement WC Breach Disable/Enable#6070

Merged
adamsaghy merged 4 commits into
apache:developfrom
openMF:FINERACT-2455/wc-breach-disable-enable
Jul 8, 2026
Merged

FINERACT-2455: Implement WC Breach Disable/Enable#6070
adamsaghy merged 4 commits into
apache:developfrom
openMF:FINERACT-2455/wc-breach-disable-enable

Conversation

@oleksii-novikov-onix

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/wc-breach-disable-enable branch 4 times, most recently from daa9755 to 7cd6920 Compare July 3, 2026 12:36
@mariiaKraievska

Copy link
Copy Markdown
Contributor

The AC mentions stopping “Breach Past Due amount evaluation”, but I don’t see any past due specific logic. @oleksii-novikov-onix Please help me to figure it out, is it out of scope for this ticket?

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksii-novikov-onix

Copy link
Copy Markdown
Contributor Author

The AC mentions stopping “Breach Past Due amount evaluation”, but I don’t see any past due specific logic. @oleksii-novikov-onix Please help me to figure it out, is it out of scope for this ticket?

Breach Past Due amount evaluation should be implemented separately, so it's intentionally out of scope here - this PR stops all breach evaluation that exists on develop today

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/wc-breach-disable-enable branch 2 times, most recently from 18e8560 to d45a859 Compare July 7, 2026 10:33
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review July 7, 2026 10:34
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/wc-breach-disable-enable branch 3 times, most recently from 8aa6c9b to c921408 Compare July 7, 2026 19:43
@adamsaghy adamsaghy force-pushed the FINERACT-2455/wc-breach-disable-enable branch from c921408 to a548615 Compare July 8, 2026 09:17
@adamsaghy adamsaghy merged commit 347694a into apache:develop Jul 8, 2026
177 of 178 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/wc-breach-disable-enable branch July 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants