Skip to content

FINERACT-2455: WC - Accounting Entries - Charge-Off Transaction - #6218

Merged
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-2455/wc-accounting-entries-charge-off-transaction
Aug 4, 2026
Merged

FINERACT-2455: WC - Accounting Entries - Charge-Off Transaction#6218
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-2455/wc-accounting-entries-charge-off-transaction

Conversation

@mariiaKraievska

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual new work (WorkingCapitalLoanChargeOffWriteServiceImpl, migration 0062_wc_loan_charge_off.xml) looks solid and consistent with established patterns. But:

This branch is carrying the entire mark-as-fraud feature (MarkWorkingCapitalLoanAsFraudRequest, the handler/service/impl, WorkingCapitalLoanMarkAsFraudTest, and a duplicate is_fraud column + SETFRAUD_WORKINGCAPITALLOAN permission insert) that already merged as a separate PR. Looks like this branch hasn't been rebased since. Worth rebasing onto current develop before this goes further - right now the diff is much bigger and harder to review than it needs to be, and it risks a Liquibase changeset collision on merge.

Will take another look once it's just the charge-off diff.

@adamsaghy
adamsaghy force-pushed the FINERACT-2455/wc-accounting-entries-charge-off-transaction branch from f704e64 to a7b8afa Compare August 4, 2026 15:16
@adamsaghy
adamsaghy marked this pull request as ready for review August 4, 2026 15:17

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit 223b4a5 into apache:develop Aug 4, 2026
179 of 180 checks passed
@adamsaghy
adamsaghy deleted the FINERACT-2455/wc-accounting-entries-charge-off-transaction branch August 4, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants