FINERACT-2455: WC - Accounting Entries - Charge-Off Transaction - #6218
Conversation
galovics
left a comment
There was a problem hiding this comment.
The actual new work (WorkingCapitalLoanChargeOffWriteServiceImpl, migration 0062_wc_loan_charge_off.xml) looks solid and consistent with established patterns. But:
This branch is carrying the entire mark-as-fraud feature (MarkWorkingCapitalLoanAsFraudRequest, the handler/service/impl, WorkingCapitalLoanMarkAsFraudTest, and a duplicate is_fraud column + SETFRAUD_WORKINGCAPITALLOAN permission insert) that already merged as a separate PR. Looks like this branch hasn't been rebased since. Worth rebasing onto current develop before this goes further - right now the diff is much bigger and harder to review than it needs to be, and it risks a Liquibase changeset collision on merge.
Will take another look once it's just the charge-off diff.
f704e64 to
a7b8afa
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.