FINERACT-1932: modularization fineract-savings - Part I - #6229
Open
alberto-art3ch wants to merge 1 commit into
Open
FINERACT-1932: modularization fineract-savings - Part I#6229alberto-art3ch wants to merge 1 commit into
alberto-art3ch wants to merge 1 commit into
Conversation
alberto-art3ch
marked this pull request as ready for review
August 5, 2026 04:05
Contributor
|
I am all for cleaning up things... but this might affect 3 GSoC projects... do we have to do this right now? |
Contributor
Author
@vidakovic We can wait for that, only which is the ETA to have the chance to get this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part I (this PR) — Moves 90 files out of fineract-provider into fineract-savings via pure git mv, with no package, path or logic changes, so no import anywhere in the repo is touched.
It unifies the split portfolio.interestratechart package (45 files: api, command, data, handler, service, starter) with the domain/incentive half that already lived in fineract-savings, and moves 45 more savings files (api 17, service 8, domain 7, data 4, four complete jobs 8, cob.savings 1).
Two build dependencies are added to fineract-savings: fineract-command (the interest rate chart handlers use the typed command framework) and spring-boot-starter-batch + spring-batch-integration (the savings scheduled jobs), matching how fineract-loan already declares them.
Part II (follow-up PR) — The remaining 101 movable files: 86 portfolio.savings.handler command handlers plus 15 savings/deposit business events; a further 47 files stay in fineract-provider for now because they depend on portfolio.account, ClientRepositoryWrapper/GroupRepositoryWrapper/StaffRepositoryWrapper, NoteRepository, or the bulkimport framework.
FINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.