Skip to content

FINERACT-1932: modularization fineract-savings - Part I - #6229

Open
alberto-art3ch wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-1932/modularization-fineract-savings-02
Open

FINERACT-1932: modularization fineract-savings - Part I#6229
alberto-art3ch wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-1932/modularization-fineract-savings-02

Conversation

@alberto-art3ch

Copy link
Copy Markdown
Contributor

Description

Part I (this PR) — Moves 90 files out of fineract-provider into fineract-savings via pure git mv, with no package, path or logic changes, so no import anywhere in the repo is touched.
It unifies the split portfolio.interestratechart package (45 files: api, command, data, handler, service, starter) with the domain/incentive half that already lived in fineract-savings, and moves 45 more savings files (api 17, service 8, domain 7, data 4, four complete jobs 8, cob.savings 1).
Two build dependencies are added to fineract-savings: fineract-command (the interest rate chart handlers use the typed command framework) and spring-boot-starter-batch + spring-batch-integration (the savings scheduled jobs), matching how fineract-loan already declares them.

Part II (follow-up PR) — The remaining 101 movable files: 86 portfolio.savings.handler command handlers plus 15 savings/deposit business events; a further 47 files stay in fineract-provider for now because they depend on portfolio.account, ClientRepositoryWrapper/GroupRepositoryWrapper/StaffRepositoryWrapper, NoteRepository, or the bulkimport framework.

FINERACT-1932

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@alberto-art3ch
alberto-art3ch marked this pull request as ready for review August 5, 2026 04:05
@vidakovic

Copy link
Copy Markdown
Contributor

I am all for cleaning up things... but this might affect 3 GSoC projects... do we have to do this right now?

@alberto-art3ch

Copy link
Copy Markdown
Contributor Author

I am all for cleaning up things... but this might affect 3 GSoC projects... do we have to do this right now?

@vidakovic We can wait for that, only which is the ETA to have the chance to get this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants