FINERACT-2747: Add unit tests for FrequencyTypeUtil - #6244
Open
shubhamchaudhary29 wants to merge 1 commit into
Open
FINERACT-2747: Add unit tests for FrequencyTypeUtil#6244shubhamchaudhary29 wants to merge 1 commit into
shubhamchaudhary29 wants to merge 1 commit into
Conversation
shubhamchaudhary29
marked this pull request as ready for review
August 7, 2026 14:16
shubhamchaudhary29
force-pushed
the
FINERACT-2747-frequency-type-util-tests
branch
from
August 7, 2026 17:28
818adf1 to
4907881
Compare
shubhamchaudhary29
marked this pull request as draft
August 7, 2026 17:37
shubhamchaudhary29
marked this pull request as ready for review
August 7, 2026 17:37
Author
|
hey @adamsaghy it would be great, if you can review this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused unit tests for
FrequencyTypeUtil.compareFrequencies.The tests cover comparisons between frequencies of the same type and conversions across days, weeks, months, and years. This documents the utility's current behaviour and protects it against regressions without changing production code.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2747
Tests
./gradlew :fineract-core:test --tests org.apache.fineract.infrastructure.core.service.FrequencyTypeUtilTest— passed (7 tests)./gradlew :fineract-core:spotlessCheck— passedgit diff --check— passedChecklist