Skip to content

Feature/fix p3 1 dockerfile - #6362

Closed
jgaitan-quida wants to merge 14 commits into
apache:developfrom
jgaitan-quida:feature/fix-p3-1-dockerfile
Closed

Feature/fix p3 1 dockerfile#6362
jgaitan-quida wants to merge 14 commits into
apache:developfrom
jgaitan-quida:feature/fix-p3-1-dockerfile

Conversation

@jgaitan-quida

Copy link
Copy Markdown

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

* test: trigger P2.3 quality check

* chore: enforce LF line endings for YAML/shell files

* fix(p2-3): apply Spotless rules to workflow (4-space indent, LF, trim ws)
* ci(p2-1): add unit tests workflow with Spotless-compliant format

* test: trigger P2.1 workflow

* fix(p2-1): exclude oauth2, twofactor and e2e test modules

* fix(p2-1): exclude integration-tests module (requires running Fineract)
* ci(p2-4): add DAST scan with OWASP ZAP via Cloudflare Quick Tunnel

* fix(p2-4): create fineract_tenants and fineract_default DBs before startup

* fix(p2-4): fail only on CRITICAL/HIGH findings (align with L.1 §6.2)

* fix(p2-4): rewrite yaml with -I flag and remove custom artifact_name

* fix(p2-4): use docker run directly for ZAP, custom exit code handling

* fix(p2-4): use pwd instead of PWD variable for docker volume

* fix(p2-4): enforce LF line endings and single trailing newline
…ks (#5)

* ci: apply gate pattern to P2.1 and P2.4 for conditional required checks

* fix: pin third-party actions by SHA (supply chain security)
* ci(p3-1): add build pipeline with Docker + Cosign keyless + Syft SBOM (actions pinned by SHA)

* feat: add Dockerfile for Fineract (SCARE-compliant, non-root, JRE 25)

* fix(p2-1): increase gradle heap and exclude fineract-client-feign buildJavaSdk

* fix(p2-1): exclude correct fineract-client module (not fineract-client-feign)

* fix(p2-1): exclude all fineract-client tasks (buildJavaSdk requires too much heap)

* fix(p2-1): run only fineract-provider:test (avoid SDK generators heap issues)
@jgaitan-quida
jgaitan-quida force-pushed the feature/fix-p3-1-dockerfile branch from 9910b9c to d86a53a Compare September 1, 2026 02:22
@DeathGun44

Copy link
Copy Markdown
Contributor

@jgaitan-quida Hi! please go through and follow the instructions present in the checklist

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not sent private changes to the upstream repository

@IOhacker

IOhacker commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Please do not sent private changes to the upstream repository

@IOhacker IOhacker closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants