[hotfix] Propagate action task Errors from mailbox#880
Merged
Conversation
github-actions
Bot
added
doc-not-needed
weiqingy
reviewed
Jul 7, 2026
|
|
||
| public static class LinkageErrorAction { | ||
| static { | ||
| if (System.nanoTime() >= 0) { |
Collaborator
There was a problem hiding this comment.
Could we make this linkage-error fixture deterministic? System.nanoTime() is permitted to return a negative value, so on a JVM where that happens the static initializer would complete normally and this regression test would fail for environmental reasons instead of exercising the intended Error-propagation path. A deterministic guard like if (true) (or an alwaysTrue() helper) keeps the fixture focused on the LinkageError path.
Catch Throwable in mailbox-submitted action task processing so Errors are rethrown through the mailbox and fail the task visibly instead of remaining in a Future while processing keys stay in-flight. Co-authored-by: Codex <codex@openai.com>
weiqingy
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch Throwable in mailbox-submitted action task processing so Errors are rethrown through the mailbox and fail the task visibly instead of remaining in a Future while processing keys stay in-flight.
Purpose of change
Catch Throwable in mailbox-submitted action task processing so Errors are rethrown through the mailbox and fail the task visibly instead of remaining in a Future while processing keys stay in-flight.
Tests
ut
API
no
Documentation
doc-neededdoc-not-neededdoc-included