[runtime] send Kafka tombstones on state pruning for durable log compaction#885
Open
rob-9 wants to merge 2 commits into
Open
[runtime] send Kafka tombstones on state pruning for durable log compaction#885rob-9 wants to merge 2 commits into
rob-9 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #691
Purpose of change
KafkaActionStateStore.pruneState()only removed entries from the in-memory cache. the underlying Kafka topic was never updated, so:rebuildState()replayed pruned records back into memory, resurrecting state that should have been discardedThis PR sends
null-valued records to the state topic during pruning, and updatesrebuildState()to skip tombstoned keys during replay instead of inserting them into the cache. Also fixes an NPE in the error-logging path that calledrecord.value().toString()on a null value.Tests
mvn --batch-mode --no-transfer-progress -pl runtime -am -Dtest=KafkaActionStateStoreTest testtestPruneStateverifies tombstones are produced and in-memory entries are evictedtestPruneStateSendsTombstonesWithCorrectKeysasserts exact composite keys on produced tombstonestestPruneStateNoMatchingKeysverifies no tombstones sent when no keys matchtestPruneStateWithNullProducerverifies graceful degradation when producer is nullAPI
No public API changes.
Documentation
doc-not-needed