Skip to content

[FLINK-27091] Add Transformer and Estimator for LinearSVC #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lindong28 merged 1 commit into from
May 7, 2022
Merged

[FLINK-27091] Add Transformer and Estimator for LinearSVC #93

lindong28 merged 1 commit into from
May 7, 2022

Conversation

@zhipeng93
Copy link
Contributor

@zhipeng93 zhipeng93 commented May 6, 2022 •
edited
Loading

What is the purpose of the change

  • Add Transformer and Estimator for LinearSVC in FlinkML.

Brief change log

  • Added Transformer and Estimator for LinearSVC.
  • Added unit test for Transformer and Estimator for LinearSVC.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (Java doc)

@zhipeng93 zhipeng93 changed the title [FLINK-27091] Add Transformer and Estimator of LinearSVC [FLINK-27091] Add Transformer and Estimator for LinearSVC May 6, 2022
@zhipeng93 zhipeng93 force-pushed the FLINK-27091 branch 2 times, most recently from 94dbf06 to 5135706 Compare May 7, 2022 01:08
@zhipeng93
Copy link
Contributor Author

zhipeng93 commented May 7, 2022

@lindong28 @yunfengzhou-hub Can you help to review this PR?

lindong28
lindong28 reviewed May 7, 2022
View reviewed changes
Copy link
Member

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good overall! Left just two minor comments.

@zhipeng93
Copy link
Contributor Author

zhipeng93 commented May 7, 2022

Thanks for the review @lindong28 . I have addressed the comments in the lastest PR.

@lindong28
Copy link
Member

lindong28 commented May 7, 2022

Thanks for the update. LGTM.

@lindong28 lindong28 merged commit 4bd9083 into apache:master May 7, 2022
@zhipeng93 zhipeng93 deleted the FLINK-27091 branch May 7, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindong28 lindong28 lindong28 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhipeng93 @lindong28