Skip to content

[FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X - #11620

Merged
JingsongLi merged 1 commit into
apache:masterfrom
JingsongLi:FLINK-16885
Apr 3, 2020
Merged

[FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X#11620
JingsongLi merged 1 commit into
apache:masterfrom
JingsongLi:FLINK-16885

Conversation

@JingsongLi

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The sql-connector-hive modules added in FLINK-16455 use wildcards imports to exclude all transitive dependencies from hive.

This is a maven 3.2.1+ feature. This may imply that Flink cannot be properly built anymore with maven 3.1 .

Brief change log

Just remove the exclusions.
The shade-plugin will remove all transitive dependencies since promoteTransitiveDependencies is false.

All declared dependencies are included in the artifactSet.

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@flinkbot

flinkbot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4183021 (Thu Apr 02 12:33:26 UTC 2020)

Warnings:

  • 4 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot

flinkbot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@lirui-apache lirui-apache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingsongLi
JingsongLi merged commit 2b94ca6 into apache:master Apr 3, 2020
@JingsongLi

Copy link
Copy Markdown
Contributor Author

Merged #11620 to master.
Thanks @lirui-apache for the review.

KarmaGYZ pushed a commit to KarmaGYZ/flink that referenced this pull request Apr 10, 2020
leonardBang pushed a commit to leonardBang/flink that referenced this pull request Apr 10, 2020
@JingsongLi
JingsongLi deleted the FLINK-16885 branch April 26, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants