[FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X - #11620
Merged
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4183021 (Thu Apr 02 12:33:26 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Contributor
Author
|
Merged #11620 to master. |
KarmaGYZ
pushed a commit
to KarmaGYZ/flink
that referenced
this pull request
Apr 10, 2020
leonardBang
pushed a commit
to leonardBang/flink
that referenced
this pull request
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The sql-connector-hive modules added in FLINK-16455 use wildcards imports to exclude all transitive dependencies from hive.
This is a maven 3.2.1+ feature. This may imply that Flink cannot be properly built anymore with maven 3.1 .
Brief change log
Just remove the exclusions.
The shade-plugin will remove all transitive dependencies since promoteTransitiveDependencies is false.
All declared dependencies are included in the artifactSet.
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation