[FLINK-2818] [runtime] Corrected javadocs of *ReduceDriver classes - #1224
Closed
ggevay wants to merge 1 commit into
Closed
[FLINK-2818] [runtime] Corrected javadocs of *ReduceDriver classes#1224ggevay wants to merge 1 commit into
ggevay wants to merge 1 commit into
Conversation
…d some methods in the API.
Contributor
|
Looks good, +1 to merge BTW: I think its not necessary to {@link} the return types - they are linked anyways in the JavaDoc. |
Contributor
|
+1 to merge. |
Member
|
I'll merge this with addressing @StephanEwen's comment. |
cfmcgrady
pushed a commit
to cfmcgrady/flink
that referenced
this pull request
Oct 23, 2015
…e methods in the API. This closes apache#1224.
lofifnc
pushed a commit
to lofifnc/flink
that referenced
this pull request
Oct 23, 2015
…e methods in the API. This closes apache#1224.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduce()method of the ReduceFunction."In the cases of ReduceDriver and AllReduceDriver, it is not the iterator which is handed to reduce(), but the elements pairwise
I guess this is not the case with AllReduceDriver and AllGroupReduceDriver. But someone who knows the code please confirm this!
There is no such thing. I guess this should be RichGroupReduceFunction.
There is no such thing. I guess this should be GroupReduceCombineDriver? (please confirm)