-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[hotfix] Fix the typo when describing checkpointed data size #12836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tCollectWithClose This closes apache#12608
….testConcurrentOnSenderBacklogAndRecycle
In this unstable unit test, the exclusive buffers and floating buffers are recycled by different
threads, which might cause unexpected race condition issue. But actually they should always be
recycled by the same task thread in practice. So we refactor the test process to recycle them in
the same thread to avoid potential unnecessary issues.
This closes apache#11924.
…ed vanilla hadoop in flink-orc
…nt & StreamPlanEnvironment This closes apache#12607
… DEBUG Being incompatible is perfectly normal, as it is for example the case if the security context isn't configured in the first place.
Before discarding a triggering checkpoint could cause a NPE which would stop the processing of subsequent checkpoint requests. This commit changes this behaviour by checking this condition and instantiating a proper exception in case that a triggering checkpoint is being discarded. This closes apache#12611.
…dinator.startTriggeringCheckpoint In order to avoid that CompletableFutures don't swallow exception they need to terminate with an exception handler. FutureUtils.assertNoException(CompletableFuture) asserts that the given future does not complete exceptionally. If it does, then the system will fail and the exception will be reported.
…missionTest This closes apache#12587.
…Test Increasing the heartbeat timeouts should harden the tests in case of slow testing machines. This closes apache#12612.
Currently, a checkpoint/savepoint barrier is always send as a priority events to the output partitions, where it overtakes data. After the fix a barrier is only a priority event iff it's unaligned. Also CheckpointCoordinator only set unaligned flag if the barrier belongs to a checkpoint. Ultimately, the unaligned checkpoint config option is not used by SubtaskCheckpointCoordinatorImpl except for initializing the channel state writer. The source of truth is now the CheckpointOptions.
This commit introduces the following updates. * Remove spec.replicas and spec.selector in jobmanager-job.yaml * Set NodePort to 30081 in jobmanager-rest-service.yaml * Use array of string for Container.args in jobmanager-job.yaml * Remove query-state port for jobmanager yaml and add to taskmanager yaml * Use log4j-console.properties for logging This closes apache#12690.
…kubernetes document
The default image used by Kubernetes is 'flink:latest' which causes version compatibility problems if the latest it not exactly the same as what you are using. The commit derives the default value from the actual Flink and Scala version, which the running Flink was built with (i.e. no longer latest). The latest tag is used only for snapshot versions until we have snapshot builds for docker images. This closes apache#11245.
…ory configuration
- execute as regular test to have proper logging - document copied code - fix typos
The test running before the failing test did not properly acknowledge the reception of the message. That's also the reason why this test always logged a timeout exception. With this change, the test will fail with timeout exceptions, and maybe this improves the overall test stability.
Correctly state org.apache.parquet:parquet-format:2.4.0 as bundled dependency
Correct bundled dependencies in NOTICE file: com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.754 -> com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.603 com.amazonaws:aws-java-sdk-s3:jar:1.11.754 -> com.amazonaws:aws-java-sdk-s3:jar:1.11.603 com.amazonaws:aws-java-sdk-kms:jar:1.11.754 -> com.amazonaws:aws-java-sdk-kms:jar:1.11.603
Remove unused dependency org.apache.commons:commons-compress:1.20 from NOTICE file This closes apache#12811.
…ormat" page into Chinese This closes apache#12774
…e:1.2.2 NOTICE file
…s:1.2.2a in flink-runtime
…rt into upsert sink This closes apache#12803
… "Streaming Concepts" This closes apache#12802
…ce training lesson' This closes apache#12778
This describes possible future work and partially the described functionality is already available with application mode.
…link-csv packaging
…Chinese This closes apache#12797
…ax-actions' of Elasticsearch This closes apache#12790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix the typo when describing checkpointed data size
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation