Skip to content

Conversation

@Myasuka
Copy link
Member

@Myasuka Myasuka commented Jul 7, 2020

What is the purpose of the change

Fix the typo when describing checkpointed data size

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

wuchong and others added 30 commits June 12, 2020 00:35
….testConcurrentOnSenderBacklogAndRecycle

In this unstable unit test, the exclusive buffers and floating buffers are recycled by different
threads, which might cause unexpected race condition issue. But actually they should always be
recycled by the same task thread in practice. So we refactor the test process to recycle them in
the same thread to avoid potential unnecessary issues.
    
This closes apache#11924.
… DEBUG

Being incompatible is perfectly normal, as it is for example the case if the security context isn't configured in the first place.
Before discarding a triggering checkpoint could cause a NPE which would stop the
processing of subsequent checkpoint requests. This commit changes this behaviour
by checking this condition and instantiating a proper exception in case that a
triggering checkpoint is being discarded.

This closes apache#12611.
…dinator.startTriggeringCheckpoint

In order to avoid that CompletableFutures don't swallow exception they need to terminate with an exception handler.
FutureUtils.assertNoException(CompletableFuture) asserts that the given future does not complete exceptionally. If
it does, then the system will fail and the exception will be reported.
…Test

Increasing the heartbeat timeouts should harden the tests in case of slow
testing machines.

This closes apache#12612.
Currently, a checkpoint/savepoint barrier is always send as a priority events to the output partitions, where it overtakes data. After the fix a barrier is only a priority event iff it's unaligned.
Also CheckpointCoordinator only set unaligned flag if the barrier belongs to a checkpoint.
Ultimately, the unaligned checkpoint config option is not used by SubtaskCheckpointCoordinatorImpl except for initializing the channel state writer. The source of truth is now the CheckpointOptions.
Arvid Heise and others added 29 commits June 29, 2020 16:11
This commit introduces the following updates.
* Remove spec.replicas and spec.selector in jobmanager-job.yaml
* Set NodePort to 30081 in jobmanager-rest-service.yaml
* Use array of string for Container.args in jobmanager-job.yaml
* Remove query-state port for jobmanager yaml and add to taskmanager yaml
* Use log4j-console.properties for logging

This closes apache#12690.
The default image used by Kubernetes is 'flink:latest' which causes version compatibility problems
if the latest it not exactly the same as what you are using.
The commit derives the default value from the actual Flink and Scala version,
which the running Flink was built with (i.e. no longer latest).
The latest tag is used only for snapshot versions until we have snapshot builds for docker images.

This closes apache#11245.
- execute as regular test to have proper logging
- document copied code
- fix typos
The test running before the failing test did not properly acknowledge the
reception of the message.
That's also the reason why this test always logged a timeout exception.

With this change, the test will fail with timeout exceptions, and maybe this
improves the overall test stability.
Correctly state org.apache.parquet:parquet-format:2.4.0 as bundled dependency
Correct bundled dependencies in NOTICE file:

com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.754 -> com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.603
com.amazonaws:aws-java-sdk-s3:jar:1.11.754 -> com.amazonaws:aws-java-sdk-s3:jar:1.11.603
com.amazonaws:aws-java-sdk-kms:jar:1.11.754 -> com.amazonaws:aws-java-sdk-kms:jar:1.11.603
Remove unused dependency org.apache.commons:commons-compress:1.20 from NOTICE file

This closes apache#12811.
This describes possible future work and partially the described
functionality is already available with application mode.
@Myasuka Myasuka closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.