[FLINK-18529][hive] Query Hive table and filter by timestamp partitio…

[lirui-apache]

…n can fail

What is the purpose of the change

Fix the issue that querying a Hive table and filter by timestamp partition column can fail.

Brief change log

• Don't try to generate date/timestamp literals in ExpressionExtractor, because such filters cannot be pushed down anyway.
• Add more test cases

Verifying this change

Existing and added tests

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? NA

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit fc30e2c (Wed Jul 08 13:40:48 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• b45b03a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[JingsongLi]

Thanks @lirui-apache , can you explain what bug in Hive?

[JingsongLi]

Minor: Add comments to explain, there are some bugs in below codes.

[lirui-apache]

Thanks @lirui-apache , can you explain what bug in Hive?

When we specify a filter like timestamp '2018-08-08 08:08:09' = p2, the type of the timestamp literal is TIMESTAMP(0). And when we try to get an object inspector for such type, HiveCatalog will throw exception because the timestamp precision is not supported.
Perhaps the root cause is that FlinkTypeFactory::leastRestrictive returns the 1st type when we call it with a List(TIMESTAMP(0), TIMESTAMP(9)). Therefore, if we change the filter to p2 = timestamp '2018-08-08 08:08:09' the query will pass.
But anyway, I think it's OK to skip generating filter for timestamp partitions because HMS doesn't support such filters.

[JingsongLi]

+1