Skip to content

[FLINK-19133] Open custom partitioners in KafkaSerializationSchemaWrapper - #13326

Merged
dawidwys merged 1 commit into
apache:masterfrom
dawidwys:flink-19133
Sep 6, 2020
Merged

[FLINK-19133] Open custom partitioners in KafkaSerializationSchemaWrapper#13326
dawidwys merged 1 commit into
apache:masterfrom
dawidwys:flink-19133

Conversation

@dawidwys

@dawidwys dawidwys commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix the issue that custom partitioners were not opened.

Brief change log

  • Moved openning of the partitioner from initProducer to open
  • Call Partitioner#open in KafkaSerializationSchemaWrapper#open

Verifying this change

Added test FlinkKafkaProducerTest#testOpenKafkaCustomPartitioner

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys
dawidwys requested a review from aljoscha September 4, 2020 06:04
@flinkbot

flinkbot commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e8a32ce (Fri Sep 04 06:13:47 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot

flinkbot commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dawidwys

dawidwys commented Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@aljoscha aljoscha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to merge once CI is green!

@dawidwys
dawidwys merged commit 25b54a5 into apache:master Sep 6, 2020
jnh5y pushed a commit to jnh5y/flink that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants