Skip to content

[FLINK-19689] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest. - #13719

Closed
xintongsong wants to merge 2 commits into
apache:masterfrom
xintongsong:FLINK-19689-external-test
Closed

[FLINK-19689] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.#13719
xintongsong wants to merge 2 commits into
apache:masterfrom
xintongsong:FLINK-19689-external-test

Conversation

@xintongsong

Copy link
Copy Markdown
Contributor

What is the purpose of the change

This PR fixes and re-activate failure tests in TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.

Brief change log

  • Add resource-types.xml to src/test/resources. This fix the failure tests.
  • Exclude resource-types.xml when building the test jar, because IT cases in flink-yarn-test (which depends on this test jar) does not work with this resource-types.xml.
  • Ignore the related tests if resource-types.xml is not loaded, in case the tests are executed directly for the test jar.

@flinkbot

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 78aebb8 (Wed Oct 21 08:31:29 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot

flinkbot commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@xintongsong
xintongsong force-pushed the FLINK-19689-external-test branch from 78aebb8 to 291bb00 Compare October 21, 2020 09:30

@tillrohrmann tillrohrmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @xintongsong. LGTM. +1 for merging after AZP gives green light.

@xintongsong

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @tillrohrmann.
Merging this since the AZP has given green light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants