[FLINK-19689] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest. - #13719
Closed
xintongsong wants to merge 2 commits into
Closed
[FLINK-19689] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.#13719xintongsong wants to merge 2 commits into
xintongsong wants to merge 2 commits into
Conversation
…ePriorityAdapterTest.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 78aebb8 (Wed Oct 21 08:31:29 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
xintongsong
force-pushed
the
FLINK-19689-external-test
branch
from
October 21, 2020 09:30
78aebb8 to
291bb00
Compare
tillrohrmann
approved these changes
Oct 21, 2020
tillrohrmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks for creating this PR @xintongsong. LGTM. +1 for merging after AZP gives green light.
Contributor
Author
|
Thanks for the review, @tillrohrmann. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes and re-activate failure tests in
TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.Brief change log
resource-types.xmltosrc/test/resources. This fix the failure tests.resource-types.xmlwhen building the test jar, because IT cases inflink-yarn-test(which depends on this test jar) does not work with thisresource-types.xml.resource-types.xmlis not loaded, in case the tests are executed directly for the test jar.