[FLINK-19814][FLINK-19815] Do not support iterations in BATCH mode. - #13795
Closed
kl0u wants to merge 2 commits into
Closed
[FLINK-19814][FLINK-19815] Do not support iterations in BATCH mode.#13795kl0u wants to merge 2 commits into
kl0u wants to merge 2 commits into
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3d0fe1e (Mon Oct 26 15:58:12 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
aljoscha
approved these changes
Oct 27, 2020
aljoscha
left a comment
aljoscha
left a comment
Contributor
There was a problem hiding this comment.
Good work! I just had some nitpicks that should be addressed but then feel free to merge.
Comment on lines
+437
to
+440
| if (shouldExecuteInBatchMode) { | ||
| throw new UnsupportedOperationException("Iterations are not supported in BATCH" + | ||
| " execution mode. If you want to execute such a pipeline, please set the " + | ||
| "'" + ExecutionOptions.RUNTIME_MODE.key() + "'=STREAMING"); |
Contributor
There was a problem hiding this comment.
Should also use the enum value instead of the hardcoded "STREAMING" string.
| if (shouldExecuteInBatchMode) { | ||
| throw new UnsupportedOperationException("Iterations are not supported in BATCH" + | ||
| " execution mode. If you want to execute such a pipeline, please set the " + | ||
| "'" + ExecutionOptions.RUNTIME_MODE.key() + "'=STREAMING"); |
| registeredTransformations, | ||
| new ExecutionConfig(), | ||
| new CheckpointConfig()); | ||
| streamGraphGenerator.setRuntimeExecutionMode(RuntimeExecutionMode.AUTOMATIC); |
Contributor
There was a problem hiding this comment.
Why don't you set it to BATCH to be more specific in the test?
kl0u
force-pushed
the
disable-batch-iterations
branch
from
October 27, 2020 13:18
3d0fe1e to
8a19ca5
Compare
Contributor
Author
|
Thanks for the comments @aljoscha. I integrated them and I will merge soon. |
kl0u
added a commit
that referenced
this pull request
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR disables iterations, i.e.
FeedbackTransformationandCoFeedbackTransformation, from theDataStreamAPI when executing inBATCHmode.Brief change log
The changes are in the
StreamGraphGenerator.Verifying this change
Added tests in the
StreamGraphGeneratorBatchExecutionTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation