[FLINK-3192] Add explain support to print ast and sql physical execution. - #1477
[FLINK-3192] Add explain support to print ast and sql physical execution.#1477gallenvara wants to merge 4 commits into
Conversation
3622263 to
1a6a993
Compare
There was a problem hiding this comment.
Why do we need this dependency?
|
Hi @gallenvara, thanks for this PR! IMO, it would be better to reuse the existing JSON plan and generate the HIVE visualization locally inside of the Table API. That would avoid to replicate quite a bit of functionality just for the sake of a different visualization. Would that work as well? In general, it is a good idea to discuss changes that modify user-facing APIs and touch several components/modules before starting to code as pointed out in our contribution guidelines. |
|
@fhueske ,thanks a lot for the review work! I'll modify the code and update the PR according to your advice. |
|
Thanks @gallenvara. Looking forward to your update :-) |
38be686 to
7a5f4b9
Compare
|
@fhueske , codes has been finished. I have drop previous method of plan-generator and rewrite a new parser named |
There was a problem hiding this comment.
can you use the ${jackson.version} variable here?
|
Hi @gallenvara, the PR looks much better. I added a few comment inline. Thanks, Fabian |
cde902c to
853b53c
Compare
There was a problem hiding this comment.
It's better to use some meaningful variable name here.
Table API doesn't support sql-explanation now. Add the explain support to print ast (abstract syntax tree) and the physical execution of sql.