[FLINK-25050][docs-zh] Translate "Metrics" page of "Operations" into Chinese #17902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ZhijieYang wants to merge 1 commit into apache:master from ZhijieYang:FLINK-25050

Contributor

ZhijieYang commented Nov 25, 2021

What is the purpose of the change

Translate "Metrics" page of "Operations" into Chinese

Brief change log

Translate "Metrics" page of "Operations" into Chinese

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

Collaborator

flinkbot commented Nov 25, 2021 •

edited

Loading

CI report:

e11b913 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run azure re-run the last Azure build

Collaborator

flinkbot commented Nov 25, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8a398a4 (Thu Nov 25 07:10:24 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!
This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

rmetzger added the component=chinese-translation label

Contributor Author

ZhijieYang commented Nov 29, 2021

@RocMarshal Hi, can you review it? thanks

RocMarshal reviewed

View reviewed changes

Contributor

RocMarshal left a comment

@ZhijieYang Thanks for the contribution.
I left some comments before line 397, hoping it will help you advance this PR.

docs/content.zh/docs/ops/metrics.md Outdated Show resolved Hide resolved

docs/content.zh/docs/ops/metrics.md Outdated Show resolved Hide resolved

docs/content.zh/docs/ops/metrics.md

    
              ## 指标类型

              Flink supports `Counters`, `Gauges`, `Histograms` and `Meters`.

              Flink 支持计数器 `Counters`，量表 `Gauges`，直方图 `Histogram` 和仪表 `Meters`。

Contributor

RocMarshal Nov 29, 2021

计数器，量表，直方图和仪表 -> What about keeping original content?

Contributor Author

ZhijieYang Nov 30, 2021

because I saw the https://nightlies.apache.org/flink/flink-docs-master/zh/docs/dev/python/table/metrics/.

docs/content.zh/docs/ops/metrics.md Outdated Show resolved Hide resolved

docs/content.zh/docs/ops/metrics.md

    
              Flink 公开了一个指标系统，允许收集和公开指标给外部系统。

              ## Registering metrics

              ## 注册指标

Contributor

RocMarshal Nov 29, 2021

missing link tag ?
The same case should be noted below.

Contributor Author

ZhijieYang Nov 30, 2021

sorry, I can't find the link here, what's your mean?

Contributor

RocMarshal Nov 30, 2021 •

edited

Loading

<a name="tegistering-metrics"></a>

You will get more relevant information in the translation part of the official documents.

docs/content.zh/docs/ops/metrics.md

    
              此方法返回一个 `MetricGroup` 对象，你可以在该对象上创建和注册新指标。

              ### Metric types

              ## 指标类型

Contributor

RocMarshal Nov 29, 2021

reduce a '#' ?
Could you give a explain for the chage ?
Glad to see the reason.

Contributor Author

ZhijieYang Nov 30, 2021

because I think Registering metrics and Metric types is on the same level, and after reduce a # we can see the details of metric types like this:

docs/content.zh/docs/ops/metrics.md

    
              A `Histogram` measures the distribution of long values.

              You can register one by calling `histogram(String name, Histogram histogram)` on a `MetricGroup`.

              直方图 `Histogram` 测量长值的分布。

Contributor

RocMarshal Nov 29, 2021

Maybe you could do it in a better way.

docs/content.zh/docs/ops/metrics.md Outdated Show resolved Hide resolved

docs/content.zh/docs/ops/metrics.md

    
              A `Meter` measures an average throughput. An occurrence of an event can be registered with the `markEvent()` method. Occurrence of multiple events at the same time can be registered with `markEvent(long n)` method.

              You can register a meter by calling `meter(String name, Meter meter)` on a `MetricGroup`.

              仪表 `Meter` 测量的是平均吞吐量。一个事件的发生率可以用 `markEvent()` 方法来注册。多个事件的发生率可以用 `markEvent(long n)` 方法注册。

Contributor

RocMarshal Nov 29, 2021 •

edited

Loading

Here's a little odd.
You could consider free translation, not just literal translation.

docs/content.zh/docs/ops/metrics.md Outdated

    
              Flink 提供了一个

              {{<gh_link file="flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/metrics/DropwizardMeterWrapper.java" name="Wrapper">}}

              ，允许使用 Codahale/DropWizard 仪表。

              要使用此仪表，请在你的 `pom.xml` 中添加：

Contributor

RocMarshal Nov 29, 2021

Same as mentioned above.


          [FLINK-25050][docs-zh] Translate "Metrics" page of "Operations" into …

e11b913

…Chinese

ZhijieYang force-pushed the FLINK-25050 branch from 603f6ad to e11b913 Compare

November 30, 2021 07:53

RocMarshal reviewed

View reviewed changes

Contributor

RocMarshal left a comment

Hi, @ZhijieYang Would you mind checking the conflicts before the next review ? Thanks a lot.

flinkbot added the component=Documentation label

chengkaiyang2025 mentioned this pull request

[FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" … #19023

Closed

github-actions bot commented Jan 15, 2025

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

1996fanrui added the stale label

github-actions bot commented Mar 30, 2025

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

github-actions bot added the closed-stale label

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale component=chinese-translation component=Documentation stale