Skip to content

[FLINK-26068] Update ZooKeeperStateHandleStore to use an indepotent r… - #18731

Merged
zentol merged 1 commit into
apache:masterfrom
dmvk:FLINK-26068
Feb 14, 2022
Merged

[FLINK-26068] Update ZooKeeperStateHandleStore to use an indepotent r…#18731
zentol merged 1 commit into
apache:masterfrom
dmvk:FLINK-26068

Conversation

@dmvk

@dmvk dmvk commented Feb 11, 2022

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/FLINK-26068

Updates ZooKeeperStateHandleStore to use an indepotent replace operation for #setStateHandle, that has been introduced in CURATOR-584, to avoid possible BadVersionException during connection issues.

Unfortunately this is not easily reproducible in Flink tests, but this code path (with the very same sentiment) is covered by the tests in Curator framework.

@flinkbot

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 54f1b25 (Fri Feb 11 13:47:36 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

…eplace operation for #setStateHandle, that has been introduced in CURATOR-584, to avoid possible BadVersionException during connection issues.
@flinkbot

flinkbot commented Feb 11, 2022

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dmvk

dmvk commented Feb 14, 2022

Copy link
Copy Markdown
Member Author

CI has failed with https://issues.apache.org/jira/browse/FLINK-20928

@dmvk

dmvk commented Feb 14, 2022

Copy link
Copy Markdown
Member Author

@flinkbot run azure

@zentol
zentol merged commit 0cf7c3d into apache:master Feb 14, 2022
@dmvk
dmvk deleted the FLINK-26068 branch February 14, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants