Skip to content

Conversation

@gallenvara
Copy link
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message

Add a check to verify the POJO has overridden the hashCode() and equals() where it used as a key for operations(join,coGroup,etc).

@fhueske
Copy link
Contributor

fhueske commented May 2, 2016

I added a comment to FLINK-2220. I think the original analysis of the problem was not correct. It is not necessary to check for POJOs whether they override equals() and hashcode(). Details in FLINK-2220

@fhueske
Copy link
Contributor

fhueske commented May 19, 2016

Any update for this PR, @gallenvara?

@gallenvara
Copy link
Contributor Author

@fhueske i can't reproduce the issue in another computer. And I'm not sure if it's because I forgot the default constructor (no parameter) that led to the problem existing. I sent email to the reporter and not responsed. I will close the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants