Skip to content

[FLINK-2220] Join on Pojo without hashCode() silently fails #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gallenvara wants to merge 1 commit into from
Closed

[FLINK-2220] Join on Pojo without hashCode() silently fails #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1688,6 +1688,19 @@ else if (typeHierarchy.size() <= 1) {

CompositeType<OUT> pojoType = new PojoTypeInfo<OUT>(clazz, pojoFields);

//POJO should override hashcode and equals method
//in the situation where it used as key for operations.
try {
clazz.getDeclaredMethod("hashCode");
} catch (NoSuchMethodException e) {
LOG.info(clazz + " should override hashCode method.");
}

try {
clazz.getDeclaredMethod("equals");
} catch (NoSuchMethodException e) {
LOG.info(clazz + " should override equals method.");
}
//
// Validate the correctness of the pojo.
// returning "null" will result create a generic type information.
Expand Down