Skip to content

[FLINK-28804][formats] Use proper stand-ins for missing metric groups - #20449

Merged
zentol merged 1 commit into
apache:masterfrom
zentol:28804
Aug 4, 2022
Merged

[FLINK-28804][formats] Use proper stand-ins for missing metric groups#20449
zentol merged 1 commit into
apache:masterfrom
zentol:28804

Conversation

@zentol

@zentol zentol commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Resolve a few cases of undesired behavior when a schema attempts to access the metric group.
We shouldn't fail in that case but silently ignore it if we have to, as we do in other areas of Flink (because a lack of metrics should never fail a job).

@zentol
zentol requested a review from alpinegizmo August 4, 2022 08:53
@flinkbot

flinkbot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@mas-chen mas-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I encountered this issue as well as in other Flink components.

It's a separate change--but what do you think about adding warning logs to UnregisteredMetricGroup to emit a log that says a metric may not be reported

@zentol

zentol commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

It's a separate change--but what do you think about adding warning logs to UnregisteredMetricGroup to emit a log that says a metric may not be reported

I'm not a fan of warnings if there's nothing the user can do about it, especially when the chance of us fixing these instances are slim.

@zentol
zentol merged commit fd26e08 into apache:master Aug 4, 2022
@zentol
zentol deleted the 28804 branch August 4, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants