Skip to content

Conversation

@link3280
Copy link
Contributor

@link3280 link3280 commented Jan 2, 2023

What is the purpose of the change

Support show jobs statement in SqlGatewayService. Subtask of FLIP-222.

Brief change log

  • Add show jobs statement in SQL parser.
  • Add show jobs operation support in the table planner.
  • Add show jobs operation support in SQL gateway.

Verifying this change

This change added tests and can be verified as follows:

  • Extend FlinkSqlParserImplTest to validate the parsing of show-jobs statements.
  • Extend SqlGatewayServiceITCase to validate the execution of show-jobs statements.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@link3280 link3280 changed the title [FLINK-28655] Support show jobs operation in SqlGateway [FLINK-28655][SQL Gateway] Support show jobs operation in SqlGateway Jan 2, 2023
@link3280 link3280 changed the title [FLINK-28655][SQL Gateway] Support show jobs operation in SqlGateway [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway Jan 2, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 2, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@link3280
Copy link
Contributor Author

link3280 commented Jan 3, 2023

@flinkbot run azure

1 similar comment
@link3280
Copy link
Contributor Author

link3280 commented Jan 6, 2023

@flinkbot run azure

@link3280
Copy link
Contributor Author

link3280 commented Jan 7, 2023

Please kindly take a look @fsk119 .

Copy link
Contributor

@LadyForest LadyForest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @link3280, thanks for the contribution. I hope you don't mind an unsolicited review.
I left some questions that are not clear to me from the FLIP doc.

@link3280
Copy link
Contributor Author

link3280 commented Jan 9, 2023

I hope you don't mind an unsolicited review.

No, absolutely not! Thanks a lot for your review! @LadyForest

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thasnks for your update. I left some comments.

@link3280
Copy link
Contributor Author

@fsk119 Thanks a lot for your review! The PR is updated as suggested.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LadyForest
Copy link
Contributor

Thanks for the update; looks good to me too.

@fsk119 fsk119 merged commit f177089 into apache:master Jan 12, 2023
@link3280
Copy link
Contributor Author

Thanks a lot! @LadyForest @fsk119

chucheng92 pushed a commit to chucheng92/flink that referenced this pull request Feb 3, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants