-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway #21582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
|
Please kindly take a look @fsk119 . |
LadyForest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @link3280, thanks for the contribution. I hope you don't mind an unsolicited review.
I left some questions that are not clear to me from the FLIP doc.
.../flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/utils/Constants.java
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
No, absolutely not! Thanks a lot for your review! @LadyForest |
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thasnks for your update. I left some comments.
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
...able-api-java/src/main/java/org/apache/flink/table/operations/command/ShowJobsOperation.java
Outdated
Show resolved
Hide resolved
.../flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/utils/Constants.java
Outdated
Show resolved
Hide resolved
|
@fsk119 Thanks a lot for your review! The PR is updated as suggested. |
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the update; looks good to me too. |
|
Thanks a lot! @LadyForest @fsk119 |
What is the purpose of the change
Support show jobs statement in SqlGatewayService. Subtask of FLIP-222.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation