Skip to content

[FLINK-30640][SqlClient] Fix unstable ctas test in CliClientITCase - #21892

Merged
fsk119 merged 1 commit into
apache:masterfrom
lsyldliu:FLINK-30640
Feb 9, 2023
Merged

[FLINK-30640][SqlClient] Fix unstable ctas test in CliClientITCase#21892
fsk119 merged 1 commit into
apache:masterfrom
lsyldliu:FLINK-30640

Conversation

@lsyldliu

@lsyldliu lsyldliu commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix the unstable ctas test in CliClientITCase, we should wait for the insert query to finish first, then query the table

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot

flinkbot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fsk119 fsk119 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsk119
fsk119 merged commit 550697a into apache:master Feb 9, 2023
lsyldliu added a commit to lsyldliu/flink that referenced this pull request Feb 9, 2023
lsyldliu added a commit to lsyldliu/flink that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants