Skip to content

Conversation

@snuyanzin
Copy link
Contributor

What is the purpose of the change

Removes the usage of the deprecated method TableTestBase#addFunction

Brief change log

Replace the usage of TableTestBase#addFunction with TableTestBase#addFunction#addTemporarySystemFunction

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 18, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin changed the title [FLINK-33597][table] Cleanup usage of deprecated TableTestBase#addFunction [FLINK-33591][table] Cleanup usage of deprecated TableTestBase#addFunction Nov 20, 2023
Copy link
Contributor

@liuyongvs liuyongvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snuyanzin added a commit to snuyanzin/flink that referenced this pull request Nov 22, 2023
Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snuyanzin snuyanzin closed this in d924230 Nov 22, 2023
@snuyanzin
Copy link
Contributor Author

thanks for taking a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants