Skip to content

Conversation

@snuyanzin
Copy link
Contributor

What is the purpose of the change

Removes the usage of the deprecated method TableEnvironment#registerFunction.

The PR is based on #23748

Brief change log

  • Replace the usage of TableEnvironment#registerFunction with TableEnvironment#createTemporarySystemFunction

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@snuyanzin snuyanzin requested a review from wuchong November 20, 2023 00:04
@snuyanzin
Copy link
Contributor Author

@wuchong since you were involved in this, could you please have a look?

It seems I found a way to clean this deprecated things

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 20, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member

wuchong commented Nov 20, 2023

cc @lincoln-lil , @LadyForest , could you help to review this?

@LadyForest
Copy link
Contributor

cc @lincoln-lil , @LadyForest , could you help to review this?

Sure. I'll take a look ASAP.

@snuyanzin
Copy link
Contributor Author

the failure is unrelated and the reason is FLINK-33568

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@LadyForest LadyForest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @snuyanzin, thanks for the contribution. The PR looks good to me, and I just left some minor comments.

@snuyanzin snuyanzin requested a review from LadyForest November 21, 2023 22:55
Copy link
Contributor

@LadyForest LadyForest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me :)

@LadyForest
Copy link
Contributor

I just noticed that the master branch has been updated, would you mind rebasing and resolving conflicts? @snuyanzin

@snuyanzin
Copy link
Contributor Author

Thanks for notifying about that, resolved the conflicts

I'm going to merge it once ci is passed

i'm going to merge as 2 commits as each commit is related to a different jira issue

Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snuyanzin snuyanzin merged commit c61c09e into apache:master Nov 22, 2023
@snuyanzin
Copy link
Contributor Author

thanks for taking a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants