-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction #23751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wuchong since you were involved in this, could you please have a look? It seems I found a way to clean this deprecated things |
|
cc @lincoln-lil , @LadyForest , could you help to review this? |
Sure. I'll take a look ASAP. |
|
the failure is unrelated and the reason is FLINK-33568 |
|
@flinkbot run azure |
LadyForest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @snuyanzin, thanks for the contribution. The PR looks good to me, and I just left some minor comments.
...anner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.scala
Outdated
Show resolved
Hide resolved
...le-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableScanTest.scala
Outdated
Show resolved
Hide resolved
...er/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverAggregateITCase.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/org/apache/flink/table/planner/runtime/utils/UserDefinedFunctionTestUtils.scala
Outdated
Show resolved
Hide resolved
...ink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/CountAggFunction.scala
Outdated
Show resolved
Hide resolved
...flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/SumAggFunction.scala
Outdated
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/CorrelateITCase.scala
Outdated
Show resolved
Hide resolved
...-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableFunctions.scala
Outdated
Show resolved
Hide resolved
...lanner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/CorrelateTest.xml
Outdated
Show resolved
Hide resolved
LadyForest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, looks good to me :)
|
I just noticed that the master branch has been updated, would you mind rebasing and resolving conflicts? @snuyanzin |
…isterFunction This closes apache#23751
1255a70 to
ae90c41
Compare
|
Thanks for notifying about that, resolved the conflicts I'm going to merge it once ci is passed i'm going to merge as 2 commits as each commit is related to a different jira issue |
JingGe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
thanks for taking a look |
What is the purpose of the change
Removes the usage of the deprecated method
TableEnvironment#registerFunction.The PR is based on #23748
Brief change log
TableEnvironment#registerFunctionwithTableEnvironment#createTemporarySystemFunctionVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation