Skip to content

Conversation

@XComp
Copy link
Contributor

@XComp XComp commented Dec 20, 2023

Based on the following PR(s):

What is the purpose of the change

See FLINK-33911 for further context.

Brief change log

  • Adds custom action

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

The Docker setup for GitHub Actions is run with root permissions. Any limitations on files are ignored because root is allowed to do anything. We haven't discovered, yet, why this works in Azure CI.
zip does not seem to be provided by default by GHA runners. A workaround
is to explicitly install it.
This fixes the following error when compiling flink-clients:
Error: 2.054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.2.0:copy-dependencies (copy-dependencies) on project flink-clients: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187. -> [Help 1]
@XComp
Copy link
Contributor Author

XComp commented Dec 20, 2023

I need to reorganize the workflow-related PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants