[FLINK-37382][runtime] Early optimization for adaptive join when either input is below broadcast threshold.#26211
Closed
SinBex wants to merge 2 commits into
Closed
[FLINK-37382][runtime] Early optimization for adaptive join when either input is below broadcast threshold.#26211SinBex wants to merge 2 commits into
SinBex wants to merge 2 commits into
Conversation
7f38d82 to
643e9f3
Compare
JunRuiLee
reviewed
Feb 26, 2025
643e9f3 to
27c3f98
Compare
…er input is below broadcast threshold.
27c3f98 to
e114ebb
Compare
Contributor
Author
|
Thanks to @JunRuiLee for reviewing, all comments have been fixed, PTAL |
…hould not chain runnables to the element queue future in a tight loop. (apache#25569)" This reverts commit 3829bb5.
Contributor
|
This GHA shows that the flink-connect tests have passed, which reverted FLINK-36585. You can find more details at https://github.com/SinBex/flink/actions/runs/13537602087. |
JunRuiLee
pushed a commit
that referenced
this pull request
Feb 26, 2025
…er input is below broadcast threshold. this closes #26211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When the large table side has not yet initialized, if the small table side finishes early and the output data volume is smaller than the broadcast threshold, the adaptive join operator can be optimized to a broadcast hash join in advance. This can help reduce network shuffle overhead.
Brief change log
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation