[FLINK-38697][runtime] Store task information blob key in JobVertex#27726
Open
DeamonDev wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38697][runtime] Store task information blob key in JobVertex#27726DeamonDev wants to merge 1 commit intoapache:masterfrom
DeamonDev wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Piotr Rudnicki <piotr.rudnicki94@protonmail.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change ensures that
TaskInformationblob keys are reused acrossExecutionGraphrebuilds triggered by the adaptive scheduler, rather than creating a new permanent blob on every restart.Previously, each time the adaptive scheduler rebuilt the
ExecutionGraph(e.g. after aTaskManagerfailure),ExecutionJobVertexwould upload a freshTaskInformationblob to theBlobServereven if the content was identical. These blob keys are randomized, which was introduced to the blob key to prevent hash-collisions in #4359.The fix caches the
PermanentBlobKeyonJobVertex, which unlikeExecutionJobVertexis never recreated during adaptive scheduler restarts. On subsequentExecutionGraphrebuilds,ExecutionJobVertexchecks ifJobVertexalready holds a cached key and reuses it instead of uploading a new blob. This mirrors the existing pattern used by job JAR blobs, which are correctly reused across restarts by storing their keys persistently in theJobGraph. Since permanent blobs are only cleaned up when a job reaches a globally terminated state, these orphaned blobs accumulate indefinitely on the JM's blob storage, eventually causing storage exhaustion and job stalling.Brief change log
TaskInformation'sPermanentBlobKeyonJobVertexto reuse it acrossExecutionGraphrebuildsVerifying this change
This change added tests and can be verified as follows:
PermanentBlobKeyis cached and reused byExecutionJobVertex'es related to givenJobVertexDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation