[FLINK-XXXXX][table] Add GEOGRAPHY logical type model#28679
Draft
davidchaava wants to merge 2 commits into
Draft
[FLINK-XXXXX][table] Add GEOGRAPHY logical type model#28679davidchaava wants to merge 2 commits into
davidchaava wants to merge 2 commits into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This draft PR adds the initial GEOGRAPHY logical type model for Flink.
It is intended to support the ongoing FLIP discussion for native GEOGRAPHY
support in Flink SQL / Table API and to make the proposed Flink-side type shape
easier to review.
This PR is not intended to be merged before the FLIP direction is agreed.
Brief change log
LogicalTypeRoot.GEOGRAPHY.GeographyType.GEOGRAPHY.GEOGRAPHYserializable string.Verifying this change
This change adds tests for the new logical type model:
LogicalTypesTestLogicalTypeParserTestDoes this pull request potentially affect one of the following parts:
Documentation