[FLINK-40301][table] Merge Calc nodes before ChangelogNormalize projection pushdown - #28882
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-40301][table] Merge Calc nodes before ChangelogNormalize projection pushdown#28882Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change fixes an optimizer issue where adjacent Calc nodes created by watermark transposition prevent unused fields from being projected out on the input side of
ChangelogNormalize. This unnecessarily increases the shuffle row width andChangelogNormalizestate size.Brief change log
FlinkCalcMergeRule.STREAM_PHYSICAL_INSTANCEtoCHANGELOG_NORMALIZE_TRANSPOSE_RULESso that Calc nodes created byWatermarkAssignerChangelogNormalizeTransposeRuleare merged beforePushCalcPastChangelogNormalizeRuleruns.testPushdownCalcNotAffectChangelogNormalizeKey2toWatermarkAssignerChangelogNormalizeTransposeRuleTest.Verifying this change
WatermarkAssignerChangelogNormalizeTransposeRuleTest#testPushdownCalcNotAffectChangelogNormalizeKey2verifies that only the required fieldfand theChangelogNormalizekeyaare projected to its input side. The rowtime fieldingestion_timeremains available toWatermarkAssignerwithout entering the shuffle orChangelogNormalizestate.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation