[FLINK-40308][tests] Rename planner *Tests classes to *Test so they execute - #28885
Closed
spuru9 wants to merge 1 commit into
Closed
[FLINK-40308][tests] Rename planner *Tests classes to *Test so they execute#28885spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…xecute flink-table-planner narrows the integration-test surefire include to **/*ITCase.*, while the root pom's unit include is **/*Test.*. Classes suffixed *Tests match neither pattern, so they were never executed and the build stayed green. Rename them to the singular *Test suffix already used by their siblings (BitmapSemanticTest, VariantSemanticTest, 43x *RestoreTest). This makes 204 previously dead tests run. Generated-by: Claude Code (claude-opus-5)
Contributor
Author
|
@snuyanzin Can you take a look? Have run the test locally, waiting for CI to pass for now. |
Collaborator
Contributor
Author
|
Sorry missed FLINK-40284, only saw FLINK-40283. So, closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
flink-table-planner/pom.xmlnarrows theintegration-testssurefire include to**/*ITCase.*, while the root pom's unit include is**/*Test.*(test.unit.pattern).Test classes suffixed
*Testsmatch neither pattern, so they are silently neverexecuted and the build still reports success.
This affects 14 classes in the planner. It is the same class of problem as FLINK-40283.
Brief change log
*SemanticTestsclasses to*SemanticTest(ChangelogNormalize,ConstraintEnforcer, DeletesByKey, FromChangelog, Join, LateralSnapshotJoin, Misc,
MultiJoin, ProcessTableFunction, Sink, ToChangelog)
LateralSnapshotJoinBatchSemanticTests,MLPredictBatchSemanticTestsProcessTableFunctionRestoreTeststoProcessTableFunctionRestoreTest{@code ...}Javadoc reference inLateralSnapshotJoinITCaseThe singular
*Testsuffix is the convention already used by the siblings of theseclasses, which do run:
BitmapSemanticTest,VariantSemanticTest, and 43*RestoreTestclasses. No logic was changed; the diff is 16 lines, all class names.Verifying this change
This change is a test rename, so the verification is that the tests now execute.
@DisabledinRestoreTestBaseTwo classes matching the same broken pattern are deliberately not included:
MLPredictSemanticTestsfails 6/6 on an unrelated upsert-key validation once itruns, tracked separately
RestoreTestCompletenessis covered by FLINK-40307Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-5)