Skip to content

[FLINK-40308][tests] Rename planner *Tests classes to *Test so they execute - #28885

Closed
spuru9 wants to merge 1 commit into
apache:masterfrom
spuru9:FLINK-40308-planner-dead-tests
Closed

[FLINK-40308][tests] Rename planner *Tests classes to *Test so they execute#28885
spuru9 wants to merge 1 commit into
apache:masterfrom
spuru9:FLINK-40308-planner-dead-tests

Conversation

@spuru9

@spuru9 spuru9 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

flink-table-planner/pom.xml narrows the integration-tests surefire include to
**/*ITCase.*, while the root pom's unit include is **/*Test.* (test.unit.pattern).
Test classes suffixed *Tests match neither pattern, so they are silently never
executed and the build still reports success.

This affects 14 classes in the planner. It is the same class of problem as FLINK-40283.

Brief change log

  • Renamed 11 stream *SemanticTests classes to *SemanticTest (ChangelogNormalize,
    ConstraintEnforcer, DeletesByKey, FromChangelog, Join, LateralSnapshotJoin, Misc,
    MultiJoin, ProcessTableFunction, Sink, ToChangelog)
  • Renamed 2 batch classes: LateralSnapshotJoinBatchSemanticTests,
    MLPredictBatchSemanticTests
  • Renamed ProcessTableFunctionRestoreTests to ProcessTableFunctionRestoreTest
  • Updated one {@code ...} Javadoc reference in LateralSnapshotJoinITCase

The singular *Test suffix is the convention already used by the siblings of these
classes, which do run: BitmapSemanticTest, VariantSemanticTest, and 43
*RestoreTest classes. No logic was changed; the diff is 16 lines, all class names.

Verifying this change

This change is a test rename, so the verification is that the tests now execute.

  • CI logs should contain all 14 renamed classes
  • Ran locally: 204 tests execute and pass, with 1 skip that is a pre-existing
    @Disabled in RestoreTestBase

Two classes matching the same broken pattern are deliberately not included:

  • MLPredictSemanticTests fails 6/6 on an unrelated upsert-key validation once it
    runs, tracked separately
  • RestoreTestCompleteness is covered by FLINK-40307

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (claude-opus-5)

…xecute

flink-table-planner narrows the integration-test surefire include to
**/*ITCase.*, while the root pom's unit include is **/*Test.*. Classes
suffixed *Tests match neither pattern, so they were never executed and
the build stayed green.

Rename them to the singular *Test suffix already used by their siblings
(BitmapSemanticTest, VariantSemanticTest, 43x *RestoreTest). This makes
204 previously dead tests run.

Generated-by: Claude Code (claude-opus-5)
@spuru9

spuru9 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@snuyanzin Can you take a look? Have run the test locally, waiting for CI to pass for now.

@flinkbot

flinkbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@spuru9

spuru9 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Sorry missed FLINK-40284, only saw FLINK-40283. So, closing as duplicate.
Also closing the 2 JIRAs. Sorry for the noise.

@spuru9 spuru9 closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants