[FLINK-40284][tests] Introduce check to guard test names - #28887
Closed
snuyanzin wants to merge 5 commits into
Closed
[FLINK-40284][tests] Introduce check to guard test names#28887snuyanzin wants to merge 5 commits into
snuyanzin wants to merge 5 commits into
Conversation
Collaborator
snuyanzin
force-pushed
the
flink40284
branch
2 times, most recently
from
August 3, 2026 10:47
03f2102 to
3c22452
Compare
snuyanzin
changed the title
snuyanzin
marked this pull request as ready for review
August 3, 2026 10:49
snuyanzin
changed the title
snuyanzin
force-pushed
the
flink40284
branch
2 times, most recently
from
August 3, 2026 11:20
707841d to
1d66730
Compare
Contributor
Author
|
now it is a part of CI |
twalthr
reviewed
Aug 3, 2026
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class CsvBulkWriterIT { | ||
| class CsvBulkWriterTest { |
Contributor
There was a problem hiding this comment.
I see some execute() in this class.
Suggested change
| class CsvBulkWriterTest { | |
| class CsvBulkWriterITCase { |
|
|
||
| /** Batch Compiled Plan tests for {@link BatchExecSortAggregate}. */ | ||
| class SortAggregateBatchRestoreTest extends BatchRestoreTestBase { | ||
| public class SortAggregateBatchRestoreTest extends BatchRestoreTestBase { |
Contributor
There was a problem hiding this comment.
Why public now? While others can stay package private.
Contributor
Author
There was a problem hiding this comment.
because of RestoreTestCompletenessTest: it tries to use reflection to execute methods...
It never failed since it was never executed before in CI
twalthr
approved these changes
Aug 3, 2026
…ng name requirements
This was referenced Aug 4, 2026
snuyanzin
added a commit
to snuyanzin/flink
that referenced
this pull request
Aug 4, 2026
…ng name requirements This closes apache#28887.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR fixes the rest of incorrectly named tests and introduces an ArchUnit test making it failing in case of violations.
Also it allows tests ending with
*Tests.*Brief change log
test renamed, archunit rule, pom
Verifying this change
tests/logs of ci
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Tool Name and Version]