[FLINK-40344][table] Support selecting computed grouping expressions - #28987
Open
beetle0915 wants to merge 5 commits into
Open
[FLINK-40344][table] Support selecting computed grouping expressions#28987beetle0915 wants to merge 5 commits into
beetle0915 wants to merge 5 commits into
Conversation
Rewrite computed grouping expressions to reference aggregate output fields and add regression tests. Generated-by: OpenAI Codex (GPT-5)
Collaborator
Add test for column function grouping to verify expanded fields are retained in the result schema.
Author
|
@flinkbot run azure |
Author
|
The latest Azure CI run has passed successfully on the current head (cd82e7c). This PR is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change fixes the selection of computed grouping expressions in the Table API.
Previously, a computed grouping expression such as
a > 10was materialized as an aggregate output field, but a subsequent projection attempted to resolve the original expression against the aggregate output. Since the original fieldawas no longer available, validation failed.Brief change log
GROUP BY.groupBy(...).select(...)and explicitgroupBy(...).aggregate(...).select(...)paths while ensuring that non-grouping expressions remain rejected.Verifying this change
This change added tests in
QueryOperationSqlSerializationTestcovering:aggregate()call.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-5)