[FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item in root directory#396
Closed
hsaputra wants to merge 1 commit intoapache:masterfrom
hsaputra:FLINK-1542_fix_BlobUtilsTest
Closed
[FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item in root directory#396hsaputra wants to merge 1 commit intoapache:masterfrom hsaputra:FLINK-1542_fix_BlobUtilsTest
hsaputra wants to merge 1 commit intoapache:masterfrom
hsaputra:FLINK-1542_fix_BlobUtilsTest
Conversation
…not create new item in root directory Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this is possible, hence to exception thrown. Need to construct a Flink test directory under directory specified under "java.io.tmpdir" and change the permission to not allow create new directory.
Contributor
Author
|
Ping for review? |
Contributor
|
Thanks, Henry. The change looks good to me. 👍 |
Contributor
|
Looks good to me as well. Will merge it with the next batch... |
Contributor
Author
|
Thanks for the review Ufuk and Stephan. Also thx for Stephan for merging it. |
Contributor
Author
|
@uce , just realized how did you render the thumbs up icon? Looks cool =) |
Contributor
|
You can do |
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
…not create new item in root directory Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this is possible, hence to exception thrown. Need to construct a Flink test directory under directory specified under "java.io.tmpdir" and change the permission to not allow create new directory. This closes apache#396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, user that run tests could have write access to root dir such as creating /cannot-create-this
is possible, hence to exception thrown.
Need to construct a Flink test directory under directory specified under "java.io.tmpdir" and change the permission to not allow create new
directory.