Skip to content

[FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item in root directory #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hsaputra wants to merge 1 commit into from
Closed

[FLINK-1542] Test case at BlobUtilsTest should not assume user could not create new item in root directory #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,45 @@

import static org.mockito.Mockito.mock;

import com.google.common.io.Files;

import org.junit.After;
import org.junit.Before;
import org.junit.Test;

import java.io.File;

public class BlobUtilsTest {

private final static String CANNOT_CREATE_THIS = "cannot-create-this";

private File blobUtilsTestDirectory;

@Before
public void before() {
// Prepare test directory
blobUtilsTestDirectory = Files.createTempDir();

blobUtilsTestDirectory.setExecutable(true, false);
blobUtilsTestDirectory.setReadable(true, false);
blobUtilsTestDirectory.setWritable(false, false);
}

@After
public void after() {
// Cleanup test directory
blobUtilsTestDirectory.delete();
}

@Test(expected = Exception.class)
public void testExceptionOnCreateStorageDirectoryFailure() {
// Should throw an Exception
BlobUtils.initStorageDirectory("/cannot-create-this");
BlobUtils.initStorageDirectory(new File(blobUtilsTestDirectory, CANNOT_CREATE_THIS).getAbsolutePath());
}

@Test(expected = Exception.class)
public void testExceptionOnCreateCacheDirectoryFailure() {
// Should throw an Exception
BlobUtils.getStorageLocation(new File("/cannot-create-this"), mock(BlobKey.class));
BlobUtils.getStorageLocation(new File(blobUtilsTestDirectory, CANNOT_CREATE_THIS), mock(BlobKey.class));
}
}