[FLINK-6695] Activate strict checkstyle in flink-contrib - #4004
Closed
zentol wants to merge 5 commits into
Closed
Conversation
zentol
changed the title
greghogan
reviewed
May 28, 2017
greghogan
left a comment
greghogan
left a comment
Contributor
There was a problem hiding this comment.
+1 with minor comments
|
|
||
| /** | ||
| * Verifies that incoming numbers are either even or odd, controlled by the constructor argument. Emitted tuples are | ||
| * enriched with a new string field containing either "even" or "odd", based on the numbers parity. |
Contributor
There was a problem hiding this comment.
numbers parity -> numbers' parity
| import org.apache.storm.topology.TopologyBuilder; | ||
|
|
||
| /** | ||
| * A simple topology that splits a number stream based the numbers parity, and verifies the result. |
| import java.util.Random; | ||
|
|
||
| /** | ||
| * A Spout implementation that broadcast random numbers across a specified number of output streams, until a specified |
Contributor
There was a problem hiding this comment.
"broadcast" -> "broadcasts"
"was" -> "is"?
| import java.util.Map; | ||
|
|
||
| /** | ||
| * A Bolt implementation that verifies meta data emitted by a {@link MetaDataSpout}. |
Contributor
There was a problem hiding this comment.
I think that this should be "metadata" but see that the class is camelcased MetaData.
Contributor
Author
|
@greghogan fixed. |
greghogan
reviewed
May 28, 2017
|
|
||
| /** | ||
| * A simple topology that splits a number stream based the numbers parity, and verifies the result. | ||
| * A simple topology that splits a numbers stream based the numbers parity, and verifies the result. |
Contributor
There was a problem hiding this comment.
What if we simplified this to "splits a number stream based on the parity"?
| /** | ||
| * A Spout implementation that broadcast random numbers across a specified number of output streams, until a specified | ||
| * count was reached. | ||
| * A Spout implementation that broadcast randoms numbers across a specified number of output streams, until a specified |
Contributor
Author
There was a problem hiding this comment.
wow. I really added the s to the wrong word...
| /** | ||
| * Verifies that incoming numbers are either even or odd, controlled by the constructor argument. Emitted tuples are | ||
| * enriched with a new string field containing either "even" or "odd", based on the numbers parity. | ||
| * enriched with a new string field containing either "even" or "odd", based on the numbers' parity. |
Contributor
There was a problem hiding this comment.
I think I got this wrong, too. Should probably be number's.
Contributor
Author
|
@greghogan fixed. |
greghogan
reviewed
May 30, 2017
|
|
||
| /** | ||
| * A simple topology that splits a numbers stream based the numbers parity, and verifies the result. | ||
| * A simple topology that splits a numbers stream based their parity, and verifies the result. |
Contributor
There was a problem hiding this comment.
This would be a "number stream" or a "stream of numbers"? And I think "based on ...".
Contributor
Author
|
@greghogan did another attempt at fixing the issues. |
Contributor
|
+1! |
Contributor
Author
|
YES! :D merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR activates the strict checkstyle for most modules in flink-contrib;
flink-tweet-inputformatis not included due to proposal to remove it in FLINK-6710.