Skip to content

[FLINK-7882][build] Fixup FLINK-7810 by excluding remaining unused jaxb dependencies#4895

Closed
pnowojski wants to merge 1 commit into
apache:masterfrom
pnowojski:f7882
Closed

[FLINK-7882][build] Fixup FLINK-7810 by excluding remaining unused jaxb dependencies#4895
pnowojski wants to merge 1 commit into
apache:masterfrom
pnowojski:f7882

Conversation

@pnowojski

Copy link
Copy Markdown
Contributor

This excludes remaining jaxb dependency, that was conflicting version used by S3 hadoop client.

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Verifying this change

This fixup was manually tested using following command

HADOOP_CONF_DIR=/etc/hadoop/conf bin/flink run -m yarn-cluster -yn 1 examples/streaming/WordCount.jar --output s3://mybucket/out --input s3://mybucket/input

on EMR release label: emr-5.9.0, Hadoop distribution: Amazon 2.7.3, with flink built:

mvn clean install -Pdocs-and-source -DskipTests -Dhadoop.version=2.7.3

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@aljoscha

Copy link
Copy Markdown
Contributor

The fix looks good (it's quite simple ... 😉).

I'll merge once Travis is green.

@pnowojski

Copy link
Copy Markdown
Contributor Author

Yes, lets wait for the tests to complete :)

@aljoscha

Copy link
Copy Markdown
Contributor

Surprisingly, the build is "ok".

I merged, could you please close the PR?

@pnowojski

Copy link
Copy Markdown
Contributor Author

Surprisingly, the build is "ok".

It hurts my feelings :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants