Skip to content

[FLINK-11217] Back to top button is missing in the Joining document a… #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leesf wants to merge 21 commits into from
Closed

[FLINK-11217] Back to top button is missing in the Joining document a… #7360

leesf wants to merge 21 commits into from

Conversation

@leesf
Copy link
Contributor

@leesf leesf commented Dec 25, 2018

What is the purpose of the change

Add back to button in Joining docs and place it to right place in Process Function docs.

Brief change log

  • Add back to button in Joining docs and place it to right place in Process Function docs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@leesf
[FLINK-11217] Back to top button is missing in the Joining document a…
b93e982 
…nd is not properly placed in the Process Function document
yanghua
yanghua reviewed Dec 25, 2018
View reviewed changes
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leesf Thanks for your contribution. Just a minor suggestion.

docs/dev/stream/operators/joining.md Outdated
</div>
</div>


Copy link
Contributor

@yanghua yanghua Dec 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a blank line is enough. What do you think?

Copy link
Contributor Author

@leesf leesf Dec 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanghua Thanks for the review. Have updated the PR to address your comment, since a blank space is a more common practice.

docs/dev/stream/operators/process_function.md Outdated

<span class="label label-info">Note</span> Stopping a timer has no effect if no such timer with the given timestamp is registered.


Copy link
Contributor

@yanghua yanghua Dec 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@leesf
[FLINK-11217] Back to top button is missing in the Joining document a…
5132b42 
…nd is not properly placed in the Process Function document
yanghua
yanghua approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, LGTM

@leesf
Copy link
Contributor Author

leesf commented Dec 25, 2018

cc @tzulitai

boshu Zheng and others added 17 commits December 26, 2018 12:19
@zentol
[hotfix][docs][metrics] Update currentLowWatermark references
4da473e
@xueyumusic @zentol
[hotfix][docs] Fix typos
cf7f2ee
@hequn8128 @sunjincheng121
[FLINK-11142][docs] Point out fields can be projected out for Positio…
fcbf91d 
…n-based Mapping

This closes apache#7352
@dianfu @sunjincheng121
[FLINK-7208][table] Optimize Min/MaxWithRetractAggFunction with DataView
33f6d06 
This closes apache#7201
@dawidwys
[hotfix][cep] Fixed timestamp for timed out partial matches
1ccc740
@dawidwys
[hotfix][cep] Fixed argument list code style
822b17f
@dawidwys
[hotfix][cep] Added test event builder
6f5b9c9
@dawidwys
[hotfix][cep] Added test harness output asserter
92eb82b
@dawidwys
[FLINK-10596][cep] Introduced PatternProcessFunction
4496809
@dawidwys
[hotfix][cep] Fixed passing runtime context
bec4a28
@dawidwys
[FLINK-10596][cep][docs] Updated cep docs with PatternProcessFunction
2b8edec
@dawidwys
[hotfix][cep] Made PatternStream immutable & changed PatternStreamBui…
54fea60 
…lder to a proper builder
@zzchun @dawidwys
[hotfix] [docs] fix typos
0605e84
@KarmaGYZ @dawidwys
[hotfix][docs] Fix incorrectly spelled "the" as "teh"
ee81c0f
@mousepotato @GJL
[FLINK-11233][core] Fix typo in JobID Javadoc
703dc91
@leesf @GJL
[hotfix][runtime] Fix typo in FlinkUserCodeClassLoaders Javadoc
5c1f458
@leesf @zentol
[hotfix][docs] Add back-to-top button to connector page
84c2970
@leesf leesf mentioned this pull request Jan 2, 2019
Merged
@leesf leesf closed this Jan 2, 2019
@leesf leesf deleted the FLINK-11217 branch January 2, 2019 07:13
@leesf leesf restored the FLINK-11217 branch January 2, 2019 07:13
@leesf leesf reopened this Jan 2, 2019
@leesf leesf closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yanghua yanghua yanghua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component=Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@leesf @yanghua @rmetzger @xueyumusic @hequn8128 @dianfu @dawidwys @zzchun @KarmaGYZ @mousepotato